Feature request 1478 #1737
Merged
Feature request 1478 #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 12, 2015 09:55
|
@HugzM ok, but can you please squash your commits and make the commit message more descriptive? |
added 2 commits
January 12, 2015 15:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have worked on request #1478 about underline position.
Now the underline position is based on TabstripPlacement property of tabControl.
Example:
if TabstripPlacement is set to Left -> Underline is located at right
Right -> underline is located at left.
About the migration of IsUnderlined Property to dependency property in control it's now not possible because the attached property can be applied on "basic" wpf Tabcontrol.
I can bring the IsUnderlined Property in MetroTabControlComponent but in this case the basic TabControl will not have the ability to have underlined items and i guess it's not the expected behaviors.
Note: Sorry I'm new contributor on github and I havent create a branch to fix my precedent item #1431 that the reason why the commits appears on this pull request . I'll be more careful in the future